3.5+ Mixing From Timescale = 0

BinaryCats

If you are mixing from an animation which has been paused (by setting that animations time to 0) The current animation is unable to progress, as it thinks it is always it is mixing due to:

float mixingFromDelta = delta * from.timeScale;
         from.trackTime += mixingFromDelta;
         entry.mixTime += mixingFromDelta;

21 Nov 2016, 15:31

I changed it to entry.timescale, and it works fine. not sure if that is what you want though?

Pharan

I suppose the logic here is that the pace of crossfading is controlled by the timescale of the previous TrackEntry.
I think an argument could be made for a crossfade rate that's independent of both TrackEntries.
The correct implementation is whatever you want, I guess. Or whatever's most common. What is most common though?

Here's the java implementation for reference: spine-runtimes/AnimationState.java at master

I'll probably move this thread to the runtimes forum. I think it's a point of discussion for AnimationState in general.

BinaryCats

yeah I doubled checked the java, didn't know if it was another typo :*

ok, but at time scale 0, should it even mix from an animation?

Nate

BinaryCats ha scritto
If you are mixing from an animation which has been paused (by setting that animations time to 0)

What does an "animations time" mean?

Pharan

I think he meant timescale.

bcats is so efficient, he doesn't type all the words. :p

BinaryCats

Pharan ha scritto

:yes:

Nate

Ah. So the question is do we want the mix scaled by the current animation or the previous animation? If the previous was playing slowly, I think it doesn't make sense to mix in the new animation slowly. Let's change from.timeScale to entry.timeScale. Any objections?

Pharan

I instinctively think there should be a mixTimeScale. But all these fields might be getting out of hand.

BinaryCats

I like the option where it doesn't break my game 🙂 (so, for now entry.timescale works for me)

Nate

I can't think of when a mixTimeScale would be useful. It makes sense that the new animation mixes in using the new animation's time scale, but the animation mixing out should keep playing at its own time scale. So the code becomes:

from.trackTime += delta * from.timeScale;
entry.mixTime += delta * entry.timeScale;